From: Aldy Hernandez Date: Sat, 12 Nov 2022 10:58:07 +0000 (+0100) Subject: [PR68097] Try to avoid recursing for floats in gimple_stmt_nonnegative_warnv_p. X-Git-Tag: basepoints/gcc-14~3082 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=822a0823c012b912f0108a4da257cd97cbcdb7a3;p=thirdparty%2Fgcc.git [PR68097] Try to avoid recursing for floats in gimple_stmt_nonnegative_warnv_p. It irks me that a PR named "we should track ranges for floating-point hasn't been closed in this release. This is an attempt to do just that. As mentioned in the PR, even though we track ranges for floats, it has been suggested that avoiding recursing through SSA defs in gimple_assign_nonnegative_warnv_p is also a goal. This patch uses a global range query (no on-demand lookups, just global ranges and minimal folding) to determine if the range of a statement is known to be non-negative. PR tree-optimization/68097 gcc/ChangeLog: * gimple-fold.cc (gimple_stmt_nonnegative_warnv_p): Call range_of_stmt for floats. --- diff --git a/gcc/gimple-fold.cc b/gcc/gimple-fold.cc index f8a1875ea3e3..c2d9c806aee3 100644 --- a/gcc/gimple-fold.cc +++ b/gcc/gimple-fold.cc @@ -68,6 +68,7 @@ along with GCC; see the file COPYING3. If not see #include "tree-ssa-strlen.h" #include "varasm.h" #include "internal-fn.h" +#include "gimple-range.h" enum strlen_range_kind { /* Compute the exact constant string length. */ @@ -9234,6 +9235,15 @@ bool gimple_stmt_nonnegative_warnv_p (gimple *stmt, bool *strict_overflow_p, int depth) { + tree type = gimple_range_type (stmt); + if (type && frange::supports_p (type)) + { + frange r; + bool sign; + if (get_global_range_query ()->range_of_stmt (r, stmt) + && r.signbit_p (sign)) + return !sign; + } switch (gimple_code (stmt)) { case GIMPLE_ASSIGN: