From: Miod Vallat <miod.vallat@powerdns.com>
Date: Wed, 20 Aug 2025 08:48:02 +0000 (+0200)
Subject: Update parseRFC1035CharString to take a std::string_view argument.
X-Git-Tag: rec-5.4.0-alpha1~298^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=822ec98339078661e2510bd1237b441ed7e97208;p=thirdparty%2Fpdns.git

Update parseRFC1035CharString to take a std::string_view argument.

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>
---

diff --git a/pdns/dnslabeltext.rl b/pdns/dnslabeltext.rl
index 27f435094d..3b02e594ca 100644
--- a/pdns/dnslabeltext.rl
+++ b/pdns/dnslabeltext.rl
@@ -3,6 +3,7 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <string>
+#include <string_view>
 #include "dnsname.hh"
 #include "namespaces.hh"
 #include "dnswriter.hh"
@@ -172,11 +173,11 @@ DNSName::string_t segmentDNSNameRaw(const char* realinput, size_t inputlen)
 
 // Reads an RFC 1035 character string from 'in', puts the resulting bytes in 'out'.
 // Returns the amount of bytes read from 'in'
-size_t parseRFC1035CharString(const std::string &in, std::string &val) {
+size_t parseRFC1035CharString(std::string_view in, std::string &val) {
 
   val.clear();
   val.reserve(in.size());
-  const char *p = in.c_str();
+  const char *p = in.data();
   const char *pe = p + in.size();
   int cs = 0;
   uint8_t escaped_octet = 0;
diff --git a/pdns/misc.hh b/pdns/misc.hh
index 482df37b2e..6c9030974e 100644
--- a/pdns/misc.hh
+++ b/pdns/misc.hh
@@ -38,6 +38,7 @@
 #include <syslog.h>
 #include <stdexcept>
 #include <string>
+#include <string_view>
 #include <cctype>
 #include <utility>
 #include <vector>
@@ -803,7 +804,7 @@ std::vector<ComboAddress> getResolvers(const std::string& resolvConfPath);
 
 DNSName reverseNameFromIP(const ComboAddress& ip);
 
-size_t parseRFC1035CharString(const std::string &in, std::string &val); // from ragel
+size_t parseRFC1035CharString(std::string_view in, std::string &val); // from ragel
 size_t parseSVCBValueListFromParsedRFC1035CharString(const std::string &in, vector<std::string> &val); // from ragel
 size_t parseSVCBValueList(const std::string &in, vector<std::string> &val);