From: 12paper <104864644+12paper@users.noreply.github.com>
Date: Sun, 10 Nov 2024 02:13:39 +0000 (+0100)
Subject: login: fix session_kill(..., KILL_LEADER,...) (#35105)
X-Git-Tag: v257-rc2~45
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8254755091847105c33e473c62cdc7621ed275bc;p=thirdparty%2Fsystemd.git

login: fix session_kill(..., KILL_LEADER,...) (#35105)

`loginctl kill-session --kill-whom=leader <N>` (or the D-Bus equivalent)
doesn't work because logind ends up calling `KillUnit(..., "main", ...)`
on a scope unit and these don't have a `MainPID` property. Here, I just
make it send a signal to the `Leader` directly.
---

diff --git a/src/login/logind-session.c b/src/login/logind-session.c
index 66b4eadf61f..7f359864dc8 100644
--- a/src/login/logind-session.c
+++ b/src/login/logind-session.c
@@ -1390,10 +1390,20 @@ SessionState session_get_state(Session *s) {
 int session_kill(Session *s, KillWhom whom, int signo) {
         assert(s);
 
-        if (!s->scope)
-                return -ESRCH;
+        switch (whom) {
+
+        case KILL_ALL:
+                if (!s->scope)
+                        return -ESRCH;
+
+                return manager_kill_unit(s->manager, s->scope, KILL_ALL, signo, NULL);
 
-        return manager_kill_unit(s->manager, s->scope, whom, signo, NULL);
+        case KILL_LEADER:
+                return pidref_kill(&s->leader, signo);
+
+        default:
+                assert_not_reached();
+        }
 }
 
 static int session_open_vt(Session *s, bool reopen) {