From: Tomas Krizek <tomas.krizek@nic.cz>
Date: Thu, 12 Dec 2019 16:19:29 +0000 (+0100)
Subject: ci: document confusing allow_failure: false
X-Git-Tag: v5.0.0~20^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8258cd084f5f2b0c42b82eca71462d4d0ecd6cc1;p=thirdparty%2Fknot-resolver.git

ci: document confusing allow_failure: false

This value seems to be the default, but it is important to have
it set explicitly, otherwise when: manual actions could be skipped

https://docs.gitlab.com/ee/ci/yaml/#whenmanual
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 637a4cc0c..1772f4d66 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -456,7 +456,7 @@ obs:trigger: &obs_trigger
     url: https://build.opensuse.org/package/show/home:CZ-NIC:$OBS_REPO/knot-resolver
   tags:
     - respdiff
-  allow_failure: false
+  allow_failure: false  # required to make when: manual action blocking
   script:
     - scripts/make-distrofiles.sh
     - echo y | scripts/build-in-obs.sh $OBS_REPO