From: Ondřej Surý <ondrej@isc.org>
Date: Mon, 1 Jul 2024 15:49:27 +0000 (+0200)
Subject: Remove superfluous memset() in isc_nmsocket_init()
X-Git-Tag: alessio/regression/026024a6ae~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=827a153d99c42a12ba48dabfcc5581c04ec488f7;p=thirdparty%2Fbind9.git

Remove superfluous memset() in isc_nmsocket_init()

The tlsstream part of the isc_nmsocket_t gets initialized via designater
initializer and doesn't need the extra memset() later; just remove it.
---

diff --git a/lib/isc/netmgr/netmgr.c b/lib/isc/netmgr/netmgr.c
index ba56506007b..d279bd5bd5f 100644
--- a/lib/isc/netmgr/netmgr.c
+++ b/lib/isc/netmgr/netmgr.c
@@ -754,8 +754,6 @@ isc___nmsocket_init(isc_nmsocket_t *sock, isc__networker_t *worker,
 
 	isc_refcount_init(&sock->references, 1);
 
-	memset(&sock->tlsstream, 0, sizeof(sock->tlsstream));
-
 	NETMGR_TRACE_LOG("isc__nmsocket_init():%p->references = %" PRIuFAST32
 			 "\n",
 			 sock, isc_refcount_current(&sock->references));