From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Fri, 12 Apr 2024 08:28:04 +0000 (+1200)
Subject: s4:dsdb:mod: repl_md: message sort uses NUMERIC_CMP()
X-Git-Tag: tdb-1.4.11~826
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=827b0c39ed0497407bfcfc5683735a165b1b0f0a;p=thirdparty%2Fsamba.git

s4:dsdb:mod: repl_md: message sort uses NUMERIC_CMP()

No change at all in the result, just saving lines and branches.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index ea7e8a0d4a4..03f4e164ca5 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -1077,10 +1077,7 @@ static int replmd_ldb_message_element_attid_sort(const struct ldb_message_elemen
 	if (a2 == NULL) {
 		return -1;
 	}
-	if (a1->attributeID_id == a2->attributeID_id) {
-		return 0;
-	}
-	return a1->attributeID_id > a2->attributeID_id ? 1 : -1;
+	return NUMERIC_CMP(a1->attributeID_id, a2->attributeID_id);
 }
 
 static void replmd_ldb_message_sort(struct ldb_message *msg,