From: Rainer Orth Date: Wed, 17 Dec 2025 12:17:32 +0000 (+0100) Subject: testsuite: c++: Skip g++.dg/cpp26/literals2.C on Solaris [PR112652] X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=829fc51a5c98c27c39046bbbeccef375236c88dd;p=thirdparty%2Fgcc.git testsuite: c++: Skip g++.dg/cpp26/literals2.C on Solaris [PR112652] The g++.dg/cpp26/literals2.C FAILs on Solaris like this: FAIL: g++.dg/cpp26/literals2.C -std=gnu++11 (test for errors, line 10) FAIL: g++.dg/cpp26/literals2.C -std=gnu++11 (test for errors, line 11) FAIL: g++.dg/cpp26/literals2.C -std=gnu++11 (test for errors, line 13) FAIL: g++.dg/cpp26/literals2.C -std=gnu++11 (test for errors, line 41) FAIL: g++.dg/cpp26/literals2.C -std=gnu++11 (test for errors, line 42) FAIL: g++.dg/cpp26/literals2.C -std=gnu++11 (test for errors, line 44) As discussed in the PR, this is an issue with the Solaris iconv implementation. While one could fix it by requiring GNU libiconv or implement a workaround in libcpp, it seems easier to just skip the test on Solaris. xfailing it isn't really an option since that would have to be applied to every single affected dg-error which seems overkill. Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu. 2024-03-13 Rainer Orth gcc/testsuite: PR c++/112652 * g++.dg/cpp26/literals2.C: Skip on Solaris. --- diff --git a/gcc/testsuite/g++.dg/cpp26/literals2.C b/gcc/testsuite/g++.dg/cpp26/literals2.C index 11e4406f111..e0e61e45c2b 100644 --- a/gcc/testsuite/g++.dg/cpp26/literals2.C +++ b/gcc/testsuite/g++.dg/cpp26/literals2.C @@ -3,6 +3,7 @@ // { dg-require-effective-target int32 } // { dg-options "-pedantic-errors -finput-charset=UTF-8 -fexec-charset=ISO-8859-1" } /* { dg-require-iconv "ISO-8859-1" } */ +/* { dg-skip-if "PR c++/112652" *-*-solaris2* } */ int a = 'abcd'; // { dg-warning "multi-character character constant" } int b = '\x61\x62\x63\x64'; // { dg-warning "multi-character character constant" }