From: Stefan Metzmacher Date: Thu, 12 Jan 2023 09:46:20 +0000 (+0100) Subject: s4:wrepl_server: make use of tstream_bsd_fail_readv_first_error(true) X-Git-Tag: talloc-2.4.2~1182 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=82b2a379e8fac89d94a1321f4df7d732f4fbfc5d;p=thirdparty%2Fsamba.git s4:wrepl_server: make use of tstream_bsd_fail_readv_first_error(true) This avoids doing useless work in case the client connection is already broken. Signed-off-by: Stefan Metzmacher Reviewed-by: Ralph Boehme Reviewed-by: Andrew Bartlett --- diff --git a/source4/wrepl_server/wrepl_in_connection.c b/source4/wrepl_server/wrepl_in_connection.c index c68214dcbd2..1cdc40968e2 100644 --- a/source4/wrepl_server/wrepl_in_connection.c +++ b/source4/wrepl_server/wrepl_in_connection.c @@ -133,6 +133,8 @@ static void wreplsrv_accept(struct stream_connection *conn) return; } socket_set_flags(conn->socket, SOCKET_FLAG_NOCLOSE); + /* as server we want to fail early */ + tstream_bsd_fail_readv_first_error(wrepl_conn->tstream, true); wrepl_conn->conn = conn; wrepl_conn->service = service; @@ -388,6 +390,9 @@ NTSTATUS wreplsrv_in_connection_merge(struct wreplsrv_partner *partner, return NT_STATUS_NO_MEMORY; } + /* we're now a server and want to fail early */ + tstream_bsd_fail_readv_first_error(wrepl_in->tstream, true); + /* * The wrepl pdu's has the length as 4 byte (initial_read_size), * packet_full_request_u32 provides the pdu length then.