From: Martin Matuska <martin@matuska.de>
Date: Wed, 7 Dec 2022 14:52:54 +0000 (+0100)
Subject: cab reader: cast to int when subtracting unsigned integers
X-Git-Tag: v3.6.2~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=82e5c297d150255e0abcdf9ac991a3f6c0038ada;p=thirdparty%2Flibarchive.git

cab reader: cast to int when subtracting unsigned integers

Found by: GitHub CodeQL
---

diff --git a/libarchive/archive_read_support_format_cab.c b/libarchive/archive_read_support_format_cab.c
index ea256cda8..4d5029b1b 100644
--- a/libarchive/archive_read_support_format_cab.c
+++ b/libarchive/archive_read_support_format_cab.c
@@ -1134,7 +1134,7 @@ cab_checksum_update(struct archive_read *a, size_t bytes)
 	}
 	if (sumbytes) {
 		int odd = sumbytes & 3;
-		if (sumbytes - odd > 0)
+		if ((int)(sumbytes - odd) > 0)
 			cfdata->sum_calculated = cab_checksum_cfdata_4(
 			    p, sumbytes - odd, cfdata->sum_calculated);
 		if (odd)