From: Pavel Filipenský Date: Fri, 7 Jan 2022 13:11:53 +0000 (+0100) Subject: s3:libnet: Fix dead code in libnet_join.c X-Git-Tag: tdb-1.4.6~173 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=82f53c8;p=thirdparty%2Fsamba.git s3:libnet: Fix dead code in libnet_join.c Found by covscan. Pair-programmed-with: Andreas Schneider Signed-off-by: Pavel Filipenský Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison --- diff --git a/source3/libnet/libnet_join.c b/source3/libnet/libnet_join.c index 02705f1c70c..00d71b97f2a 100644 --- a/source3/libnet/libnet_join.c +++ b/source3/libnet/libnet_join.c @@ -2669,7 +2669,6 @@ static WERROR libnet_DomainJoin(TALLOC_CTX *mem_ctx, ADS_STATUS ads_status; #endif /* HAVE_ADS */ const char *pre_connect_realm = NULL; - const char *numeric_dcip = NULL; const char *sitename = NULL; struct netr_DsRGetDCNameInfo *info; const char *dc; @@ -2731,7 +2730,6 @@ static WERROR libnet_DomainJoin(TALLOC_CTX *mem_ctx, return WERR_NERR_DCNOTFOUND; } - numeric_dcip = info->dc_address + 2; sitename = info->dc_site_name; /* info goes out of scope but the memory stays allocated on the talloc context */ @@ -2741,8 +2739,9 @@ static WERROR libnet_DomainJoin(TALLOC_CTX *mem_ctx, if (pre_connect_realm != NULL) { struct sockaddr_storage ss = {0}; + const char *numeric_dcip = info->dc_address + 2; - if (numeric_dcip != NULL) { + if (numeric_dcip[0] == '\0') { if (!interpret_string_addr(&ss, numeric_dcip, AI_NUMERICHOST)) { DBG_ERR(