From: Victor Julien <victor@inliniac.net>
Date: Wed, 4 Jul 2018 13:10:34 +0000 (+0200)
Subject: detect: fix memory leak in app-layer-event keyword
X-Git-Tag: suricata-4.0.5~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=82fa3bc1248f03cae75c0de43ce17567b1813a06;p=thirdparty%2Fsuricata.git

detect: fix memory leak in app-layer-event keyword

Bug #2515.
---

diff --git a/src/detect-app-layer-event.c b/src/detect-app-layer-event.c
index 02e58560a1..ed4f7fdc8d 100644
--- a/src/detect-app-layer-event.c
+++ b/src/detect-app-layer-event.c
@@ -310,6 +310,9 @@ static int DetectAppLayerEventSetupP2(Signature *s,
     if (DetectAppLayerEventParseAppP2((DetectAppLayerEventData *)sm->ctx, s->proto.proto,
                                       &event_type) < 0) {
         /* DetectAppLayerEventParseAppP2 prints errors */
+
+        /* sm has been removed from lists by DetectAppLayerEventPrepare */
+        SigMatchFree(sm);
         return -1;
     }
     SigMatchAppendSMToList(s, sm, g_applayer_events_list_id);