From: Sami Kerola <kerolasa@iki.fi>
Date: Sun, 18 Mar 2012 20:38:39 +0000 (+0100)
Subject: tools: config-gen: make scripts bourne sh compliant [checkbashisms]
X-Git-Tag: v2.22-rc1~570
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=83134551610941b11081128fcce12ba95ed47964;p=thirdparty%2Futil-linux.git

tools: config-gen: make scripts bourne sh compliant [checkbashisms]

$ checkbashisms config-gen
script config-gen does not appear to be a /bin/sh script
possible bashism in config-gen line 27 (export foo=bar should be foo=bar; export foo):
        export CFLAGS="$CFLAGS"
$ checkbashisms config-gen-functions.sh
possible bashism in config-gen-functions.sh line 14 ('function' is useless):

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/tools/config-gen b/tools/config-gen
index 441e5a4650..720c5a7dd3 100755
--- a/tools/config-gen
+++ b/tools/config-gen
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh
 #
 # Copyright (C) 2011 Karel Zak <kzak@redhat.com> 
 # 
@@ -24,7 +24,8 @@ for x in $opts; do
 done
 if [ -n "$CFLAGS" ]; then
 	echo "CFLAGS:	$CFLAGS"
-	export CFLAGS="$CFLAGS"
+	CFLAGS="$CFLAGS"
+	export CFLAGS
 fi
 
 echo
diff --git a/tools/config-gen-functions.sh b/tools/config-gen-functions.sh
index 4f0e575f60..17e5a41e74 100644
--- a/tools/config-gen-functions.sh
+++ b/tools/config-gen-functions.sh
@@ -11,7 +11,7 @@
 #
 #    ul_get_configuration $top_srcdir/tools/config-gen.d/all
 #
-function ul_get_configuration {
+ul_get_configuration() {
 	local conf="$1"
 	local dir=$(dirname $1)
 	local opts=$(cat $conf)