From: Aleš Mrázek <ales.mrazek@nic.cz>
Date: Wed, 23 Nov 2022 00:11:05 +0000 (+0100)
Subject: manager: client: config path completion
X-Git-Tag: v6.0.0a1~12^2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8326359559eca5b33432b7ae875dd471a42e0b1b;p=thirdparty%2Fknot-resolver.git

manager: client: config path completion
---

diff --git a/manager/knot_resolver_manager/cli/cmd/completion.py b/manager/knot_resolver_manager/cli/cmd/completion.py
index fc541b867..4e4146ac9 100644
--- a/manager/knot_resolver_manager/cli/cmd/completion.py
+++ b/manager/knot_resolver_manager/cli/cmd/completion.py
@@ -39,16 +39,6 @@ def _subparser_words(unknown_args: List[str], actions: List[argparse.Action]) ->
     return None
 
 
-def subparser_comp(parser: argparse.ArgumentParser) -> Dict[str, Optional[str]]:
-    comp: Dict[str, Optional[str]] = {}
-
-    for action in parser._actions:
-        if isinstance(action, (argparse._StoreConstAction, argparse._HelpAction)):
-            for s in action.option_strings:
-                comp[s] = action.help
-    return comp
-
-
 @register_command
 class CompletionCommand(Command):
     def __init__(self, namespace: argparse.Namespace, unknown_args: List[str]) -> None:
diff --git a/manager/knot_resolver_manager/cli/cmd/config.py b/manager/knot_resolver_manager/cli/cmd/config.py
index c5febc3bd..84673e283 100644
--- a/manager/knot_resolver_manager/cli/cmd/config.py
+++ b/manager/knot_resolver_manager/cli/cmd/config.py
@@ -1,12 +1,13 @@
 import argparse
 import json
 from enum import Enum
-from typing import Dict, List, Optional, Tuple, Type
+from typing import Any, Dict, List, Optional, Tuple, Type
 
 import yaml
 from typing_extensions import Literal
 
 from knot_resolver_manager.cli.command import Command, CommandArgs, register_command
+from knot_resolver_manager.datamodel.config_schema import KresConfig
 from knot_resolver_manager.utils.modeling import try_to_parse
 from knot_resolver_manager.utils.requests import request
 
@@ -39,6 +40,41 @@ def reformat(data: str, req_format: Formats) -> str:
     return json.dumps(dict, indent=4)
 
 
+def properties_comp(props: Dict[str, Any]) -> Dict[str, Optional[str]]:
+    comp: Dict[str, Optional[str]] = {}
+    for name, prop in props.items():
+        comp[name] = prop["description"] if "description" in prop else None
+    return comp
+
+
+def node_comp(nodes: List[str], props: Dict[str, Any]) -> Dict[str, Optional[str]]:
+
+    if len(nodes) > 1 and nodes[0] in props:
+        prop = props[nodes[0]]
+        if "properties" in prop:
+            return node_comp(nodes[1:], prop["properties"])
+        else:
+            return {}
+    else:
+        return properties_comp(props)
+
+
+def config_path_comp(path: str) -> Dict[str, Optional[str]]:
+    nodes = path[1:].split("/") if path.startswith("/") else path.split("/")
+    properties: Dict[str, Any] = KresConfig.json_schema()["properties"]
+    return node_comp(nodes, properties)
+
+
+def subparser_comp(parser: argparse.ArgumentParser) -> Dict[str, Optional[str]]:
+    comp: Dict[str, Optional[str]] = {}
+
+    for action in parser._actions:
+        if isinstance(action, (argparse._StoreConstAction, argparse._HelpAction)):
+            for s in action.option_strings:
+                comp[s] = action.help
+    return comp
+
+
 @register_command
 class ConfigCommand(Command):
     def __init__(self, namespace: argparse.Namespace, unknown_args: List[str]) -> None:
@@ -110,8 +146,18 @@ class ConfigCommand(Command):
 
     @staticmethod
     def completion(args: List[str], parser: argparse.ArgumentParser) -> Dict[str, Optional[str]]:
-        comp: Dict[str, Optional[str]] = {}
-        return comp
+        top_comp = subparser_comp(parser)
+
+        for arg in args:
+            if arg in top_comp:
+                continue
+            elif arg.startswith("-"):
+                return top_comp
+            elif arg == args[-1]:
+                return config_path_comp(arg)
+            else:
+                break
+        return {}
 
     def run(self, args: CommandArgs) -> None:
         if not self.path.startswith("/"):