From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 21 Mar 2025 14:01:21 +0000 (+0100)
Subject: meson: Fix a few consistency nits
X-Git-Tag: dnsdist-2.0.0-alpha2~114^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=836b850ce85a8de5f3c70ac661844d0a9fe5a6b2;p=thirdparty%2Fpdns.git

meson: Fix a few consistency nits
---

diff --git a/meson/dnstap/meson.build b/meson/dnstap/meson.build
index e7a487ef51..58dfe839dc 100644
--- a/meson/dnstap/meson.build
+++ b/meson/dnstap/meson.build
@@ -14,4 +14,3 @@ endif
 
 conf.set('HAVE_FSTRM', dep_dnstap.found(), description: 'libfstrm')
 summary('DNSTAP', dep_dnstap.found(), bool_yn: true, section: 'Configuration')
-
diff --git a/meson/hardening/meson.build b/meson/hardening/meson.build
index 1859c63baf..3d5af7ad3f 100644
--- a/meson/hardening/meson.build
+++ b/meson/hardening/meson.build
@@ -1,5 +1,5 @@
 opt_hardening = get_option('hardening')
-if opt_hardening.enabled() or opt_hardening.auto()
+if opt_hardening.allowed()
   hardening_features = []
 
   # PIE
diff --git a/meson/libssl/meson.build b/meson/libssl/meson.build
index 387d5514f6..06b6315999 100644
--- a/meson/libssl/meson.build
+++ b/meson/libssl/meson.build
@@ -20,23 +20,23 @@ if dep_libssl.found()
     has = cxx.has_function(func, dependencies: dep_libssl)
     conf.set('HAVE_' + func.to_upper(), has, description: 'Have OpenSSL libssl ' + func)
   endforeach
-endif
 
-has = cxx.has_header_symbol(
-  'openssl/ssl.h',
-  'SSL_CTX_set_min_proto_version',
-  dependencies: dep_libssl,
-)
-conf.set(
-  'HAVE_SSL_CTX_SET_MIN_PROTO_VERSION',
-  has,
-  description: 'Have OpenSSL libssl SSL_CTX_set_min_proto_version',
-)
-conf.set(
-  'OPENSSL_NO_ENGINE',
-  true,
-  description: 'Disable engine support for auth in libssl.cc',
-)
+  has = cxx.has_header_symbol(
+    'openssl/ssl.h',
+    'SSL_CTX_set_min_proto_version',
+    dependencies: dep_libssl,
+  )
+  conf.set(
+    'HAVE_SSL_CTX_SET_MIN_PROTO_VERSION',
+    has,
+    description: 'Have OpenSSL libssl SSL_CTX_set_min_proto_version',
+  )
+  conf.set(
+    'OPENSSL_NO_ENGINE',
+    true,
+    description: 'Disable engine support for auth in libssl.cc',
+  )
+endif
 
 conf.set('HAVE_LIBSSL', dep_libssl.found(), description: 'OpenSSL libssl')
 summary('OpenSSL libssl', dep_libssl.found(), bool_yn: true, section: 'Crypto')
diff --git a/meson/libsystemd/meson.build b/meson/libsystemd/meson.build
index 416c4f1b58..42a005dbf9 100644
--- a/meson/libsystemd/meson.build
+++ b/meson/libsystemd/meson.build
@@ -1,9 +1,9 @@
 opt_systemd = get_option('systemd-service')
 
-dep_libsystemd = dependency('', required: false)
-
 if opt_systemd.allowed()
   dep_libsystemd = dependency('libsystemd', required: opt_systemd)
+else
+  dep_libsystemd = dependency('', required: false)
 endif
 
 conf.set('HAVE_SYSTEMD', dep_libsystemd.found(), description: 'libsystemd')
diff --git a/meson/systemd/meson.build b/meson/systemd/meson.build
index fe8a594d98..c6afff82c6 100644
--- a/meson/systemd/meson.build
+++ b/meson/systemd/meson.build
@@ -1,9 +1,10 @@
 opt_systemd = get_option('systemd-service')
 
-dep_systemd_prog = dependency('', required: false)
 
 if opt_systemd.allowed()
   dep_systemd_prog = dependency('systemd', required: opt_systemd)
+else
+  dep_systemd_prog = dependency('', required: false)
 endif
 
 if dep_systemd_prog.found()
diff --git a/pdns/dnsdistdist/meson/re2/meson.build b/pdns/dnsdistdist/meson/re2/meson.build
index 8ef952dce2..6b046fda3d 100644
--- a/pdns/dnsdistdist/meson/re2/meson.build
+++ b/pdns/dnsdistdist/meson/re2/meson.build
@@ -2,10 +2,10 @@ opt_libre2 = get_option('re2')
 dep_libre2 = dependency('re2', required: opt_libre2)
 
 if dep_libre2.found()
-    # we need to NOT pick the CFLAGS because re2 "helpfully" puts -std=c++11 here
-    dep_libre2 = dep_libre2.partial_dependency(
-        link_args: true
-    )
+  # we need to NOT pick the CFLAGS because re2 "helpfully" puts -std=c++11 here
+  dep_libre2 = dep_libre2.partial_dependency(
+      link_args: true
+  )
 endif
 
 conf.set('HAVE_RE2', dep_libre2.found(), description: 're2')
diff --git a/pdns/dnsdistdist/meson_options.txt b/pdns/dnsdistdist/meson_options.txt
index 1e91d47d0c..8f83ff2b24 100644
--- a/pdns/dnsdistdist/meson_options.txt
+++ b/pdns/dnsdistdist/meson_options.txt
@@ -11,7 +11,6 @@ option('hardening-experimental-cf', type: 'combo', choices: ['disabled', 'full',
 option('hardening-experimental-scp', type: 'feature', value: 'disabled', description: 'Stack Clash Protection')
 option('hardening-fortify-source', type: 'combo', choices: ['auto', 'disabled', '1', '2', '3'], value: '2', description: 'Source fortification level')
 option('ipcipher', type: 'feature', value: 'auto', description: 'IPCipher')
-#option('rng-kiss', type: 'boolean', value: false, description: 'Use the unsafe KISS RNG')
 option('tls-libssl', type: 'feature', value: 'auto', description: 'OpenSSL-based TLS')
 option('tls-libssl-providers', type: 'boolean', value: false, description: 'OpenSSL-based TLS with TLS providers')
 option('dns-over-tls', type: 'boolean', value: false, description: 'DNS over TLS (requires GnuTLS or OpenSSL)')