From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Wed, 17 Nov 2021 15:16:04 +0000 (+0100)
Subject: MINOR: quic: Wrong largest acked packet number parsing
X-Git-Tag: v2.5-dev15~12
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=83b7a5b490929fe43c6c62a9e29e8f6f5e435b0d;p=thirdparty%2Fhaproxy.git

MINOR: quic: Wrong largest acked packet number parsing

When we have already received ACK frames with the same largest packet
number, this is not an error at all. In this case, we must continue
to parse the ACK current frame.
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index eee13a26f1..7508b276bb 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -1511,11 +1511,11 @@ static inline int qc_parse_ack_frm(struct quic_frame *frm, struct ssl_sock_ctx *
 		if (!largest_node) {
 			TRACE_DEVEL("Largest acked packet not found",
 			            QUIC_EV_CONN_PRSAFRM, ctx->conn);
-			goto err;
 		}
-
-		time_sent = eb64_entry(&largest_node->node,
-		                       struct quic_tx_packet, pn_node)->time_sent;
+		else {
+			time_sent = eb64_entry(&largest_node->node,
+			                       struct quic_tx_packet, pn_node)->time_sent;
+		}
 	}
 
 	TRACE_PROTO("ack range", QUIC_EV_CONN_PRSAFRM,