From: Ralph Boehme <slow@samba.org>
Date: Fri, 8 Nov 2024 12:09:15 +0000 (+0100)
Subject: smbtorture: remove more allocation size checks
X-Git-Tag: tdb-1.4.13~617
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=83bca29e9dfc7f7f3e70067de1118ef5971e9646;p=thirdparty%2Fsamba.git

smbtorture: remove more allocation size checks

If the requested allocation size was 0, the resulting allocation size may be
larger due to xattrs and other filesystem dependent factors.

Cf commits fba4b290856faaf17305103efc65f6383ea4f61c and
55b2f247f9ba56516efba52481418966a777343e.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/source4/torture/raw/open.c b/source4/torture/raw/open.c
index f4eeb4e8c6e..69b698d5ea0 100644
--- a/source4/torture/raw/open.c
+++ b/source4/torture/raw/open.c
@@ -835,7 +835,6 @@ static bool test_ntcreatex(struct torture_context *tctx, struct smbcli_state *cl
 	CHECK_ALL_INFO(io.ntcreatex.out.attrib, attrib);
 	CHECK_VAL(io.ntcreatex.out.attrib & ~FILE_ATTRIBUTE_NONINDEXED,
 		  FILE_ATTRIBUTE_DIRECTORY);
-	CHECK_ALL_INFO(io.ntcreatex.out.alloc_size, alloc_size);
 	CHECK_ALL_INFO(io.ntcreatex.out.size, size);
 	CHECK_ALL_INFO(io.ntcreatex.out.is_directory, directory);
 	CHECK_VAL(io.ntcreatex.out.is_directory, 1);
@@ -1107,7 +1106,6 @@ static bool test_nttrans_create(struct torture_context *tctx, struct smbcli_stat
 	CHECK_ALL_INFO(io.ntcreatex.out.attrib, attrib);
 	CHECK_VAL(io.ntcreatex.out.attrib & ~FILE_ATTRIBUTE_NONINDEXED,
 		  FILE_ATTRIBUTE_DIRECTORY);
-	CHECK_ALL_INFO(io.ntcreatex.out.alloc_size, alloc_size);
 	CHECK_ALL_INFO(io.ntcreatex.out.size, size);
 	CHECK_ALL_INFO(io.ntcreatex.out.is_directory, directory);
 	CHECK_VAL(io.ntcreatex.out.is_directory, 1);
@@ -2161,7 +2159,6 @@ static bool test_ntcreatex_supersede(struct torture_context *tctx, struct smbcli
 	CHECK_NTTIME(io.ntcreatex.out.write_time, write_time);
 	CHECK_NTTIME(io.ntcreatex.out.change_time, change_time);
 	CHECK_ALL_INFO(io.ntcreatex.out.attrib, attrib);
-	CHECK_ALL_INFO(io.ntcreatex.out.alloc_size, alloc_size);
 	CHECK_ALL_INFO(io.ntcreatex.out.size, size);
 	CHECK_ALL_INFO(io.ntcreatex.out.is_directory, directory);
 	CHECK_VAL(io.ntcreatex.out.file_type, FILE_TYPE_DISK);
@@ -2189,7 +2186,6 @@ static bool test_ntcreatex_supersede(struct torture_context *tctx, struct smbcli
 	CHECK_NTTIME(io.ntcreatex.out.write_time, write_time);
 	CHECK_NTTIME(io.ntcreatex.out.change_time, change_time);
 	CHECK_ALL_INFO(io.ntcreatex.out.attrib, attrib);
-	CHECK_ALL_INFO(io.ntcreatex.out.alloc_size, alloc_size);
 	CHECK_VAL(io.ntcreatex.out.size, 512);
 	CHECK_ALL_INFO(io.ntcreatex.out.is_directory, directory);
 	CHECK_VAL(io.ntcreatex.out.file_type, FILE_TYPE_DISK);
@@ -2213,7 +2209,6 @@ static bool test_ntcreatex_supersede(struct torture_context *tctx, struct smbcli
 	CHECK_NTTIME(io.ntcreatex.out.create_time, create_time);
 	CHECK_NTTIME(io.ntcreatex.out.access_time, access_time);
 	CHECK_ALL_INFO(io.ntcreatex.out.attrib, attrib);
-	CHECK_ALL_INFO(io.ntcreatex.out.alloc_size, alloc_size);
 	CHECK_ALL_INFO(io.ntcreatex.out.is_directory, directory);
 	CHECK_VAL(io.ntcreatex.out.file_type, FILE_TYPE_DISK);
 done: