From: Eric Wong <e@80x24.org>
Date: Thu, 14 Sep 2023 20:52:05 +0000 (+0000)
Subject: test_common: eliminate call to non-existent cleanup_task
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=83cf082e4f5162c92ae6b4b87e79a6115a9fde6b;p=thirdparty%2Fpublic-inbox.git

test_common: eliminate call to non-existent cleanup_task

cleanup_task is long gone since all that cleanup work got moved
into DS itself.  Adding a DS->Reset here breaks t/imapd.t (and
possibly other tests), and is actually unlikely to avoid any
cleanup segfaults on OpenBSD since those are only happening
after `END {}' blocks are called.
---

diff --git a/lib/PublicInbox/TestCommon.pm b/lib/PublicInbox/TestCommon.pm
index a8323e4d9..4c819a4ff 100644
--- a/lib/PublicInbox/TestCommon.pm
+++ b/lib/PublicInbox/TestCommon.pm
@@ -365,7 +365,8 @@ sub run_script ($;$$) {
 			chdir $d or die "chdir $d: $!";
 		}
 		_run_sub($sub, $key, \@argv);
-		eval { PublicInbox::Inbox::cleanup_task() };
+		# n.b. all our uses of PublicInbox::DS should be fine
+		# with this and we can't Reset here.
 		die "fchdir(restore): $!" if $cwdfh && !chdir($cwdfh);
 		_undo_redirects($orig_io);
 		select STDOUT;