From: DIALLO David <diallo@et.esiea.fr>
Date: Mon, 15 Dec 2014 15:45:39 +0000 (+0100)
Subject: fix CID 1257762:  Logically dead code(DEADCODE)
X-Git-Tag: suricata-2.1beta3~98
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=83d9834e776e5fdd9f1df6e17e5c8b0517cd5184;p=thirdparty%2Fsuricata.git

fix CID 1257762:  Logically dead code(DEADCODE)
---

diff --git a/src/app-layer-modbus.c b/src/app-layer-modbus.c
index 7d23bcacc4..d2518b5313 100644
--- a/src/app-layer-modbus.c
+++ b/src/app-layer-modbus.c
@@ -829,7 +829,7 @@ static int ModbusParseDiagnosticRequest(ModbusTransaction   *tx,
     if (tx->subFunction != MODBUS_SUBFUNC_QUERY_DATA) {
         switch (tx->subFunction) {
             case MODBUS_SUBFUNC_RESTART_COM:
-                if ((data != 0x00) || (data != 0xFF00))
+                if ((data != 0x00) && (data != 0xFF00))
                     goto error;
                 break;