From: Nick Terrell <terrelln@fb.com>
Date: Wed, 8 Feb 2023 19:42:46 +0000 (-0800)
Subject: Fix empty-block.zst golden decompression file
X-Git-Tag: v1.5.4^2~4^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=83f8a05f87cc5ee94aca47d250980bde22bb7bf1;p=thirdparty%2Fzstd.git

Fix empty-block.zst golden decompression file

This frame is invalid because the `Window_Size = 0`, and the
`Block_Maximum_Size = min(128 KB, Window_Size) = 0`. But the empty
compressed block has a `Block_Content` size of 2, which is invalid.

The fix is to switch to using a `Window_Descriptor` instead of the
`Single_Segment_Flag`. This sets the `Window_Size = 1024`.

Hexdump before this PR: `28b5 2ffd 2000 1500 0000 00`

Hexdump after this PR: `28b5 2ffd 0000 1500 0000 00`

For issue #3482.
---

diff --git a/tests/golden-decompression/empty-block.zst b/tests/golden-decompression/empty-block.zst
index 2a3782aff..fbfb893e1 100644
Binary files a/tests/golden-decompression/empty-block.zst and b/tests/golden-decompression/empty-block.zst differ