From: ryb <ryb@ableton.com>
Date: Sat, 7 Feb 2015 14:30:16 +0000 (+0100)
Subject: Don't clean up the clang diagnostics file in failure cases
X-Git-Tag: v3.2.2~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8411ed8b2f8edfb36999ba4a8bbc280d9f92c175;p=thirdparty%2Fccache.git

Don't clean up the clang diagnostics file in failure cases

It isn't necessary to remove the file as it will be overwritten when re-running
the compiler in failed(). tmp_unlink() is the wrong function to use in any case,
as the file is not temporary and could be on an NFS volume (see the comment for
tmp_unlink()).
---

diff --git a/ccache.c b/ccache.c
index 581d59c41..ce6da8a27 100644
--- a/ccache.c
+++ b/ccache.c
@@ -781,9 +781,6 @@ to_cache(struct args *args)
 		stats_update(STATS_STDOUT);
 		tmp_unlink(tmp_stdout);
 		tmp_unlink(tmp_stderr);
-		if (output_dia) {
-			tmp_unlink(output_dia);
-		}
 		failed();
 	}
 	tmp_unlink(tmp_stdout);
@@ -845,9 +842,6 @@ to_cache(struct args *args)
 		}
 
 		tmp_unlink(tmp_stderr);
-		if (output_dia) {
-			tmp_unlink(output_dia);
-		}
 		failed();
 	}