From: Mark Andrews Date: Wed, 5 Feb 2020 05:15:35 +0000 (+1100) Subject: 'dctx' must be non NULL, remove test. X-Git-Tag: v9.16.0~29^2~10 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8456b5627dd36982a83778b4528ec09ade1f6dc3;p=thirdparty%2Fbind9.git 'dctx' must be non NULL, remove test. 11030 cleanup: CID 1452705 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking dctx suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 11031 if (dctx != NULL) 11032 dumpcontext_destroy(dctx); 11033 return (result); --- diff --git a/bin/named/server.c b/bin/named/server.c index 0af78773b8e..3acd9ad0e64 100644 --- a/bin/named/server.c +++ b/bin/named/server.c @@ -11028,8 +11028,7 @@ named_server_dumpdb(named_server_t *server, isc_lex_t *lex, return (ISC_R_SUCCESS); cleanup: - if (dctx != NULL) - dumpcontext_destroy(dctx); + dumpcontext_destroy(dctx); return (result); }