From: Jan Doskočil <jan.doskocil@nic.cz>
Date: Tue, 13 Jan 2026 09:51:06 +0000 (+0100)
Subject: keymgr: avoid segfault when using import-pem on a malformed key
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=847c031af234bfbd09d375b8ddf29fb0045fe4c1;p=thirdparty%2Fknot-dns.git

keymgr: avoid segfault when using import-pem on a malformed key

Co-authored-by: Hanno Böck <hanno@hboeck.de>
---

diff --git a/src/utils/keymgr/functions.c b/src/utils/keymgr/functions.c
index bbb2f8faf1..df00464aae 100644
--- a/src/utils/keymgr/functions.c
+++ b/src/utils/keymgr/functions.c
@@ -501,9 +501,12 @@ fail:
 
 static void err_import_key(char *keyid, const char *file)
 {
+	assert(file != NULL);
+
 	ERR2("failed to get key%s%s from %s%s",
-	     *keyid == '\0' ? "" : " ", keyid,
-	     *file == '\0' ? "the keystore" : "file ", file);
+	     (keyid == NULL || *keyid == '\0') ? "" : " ",
+	     (keyid == NULL) ? "" : keyid,
+	     (*file == '\0') ? "the keystore" : "file ", file );
 }
 
 static int import_key(kdnssec_ctx_t *ctx, unsigned backend, const char *param,