From: Volker Lendecke <vl@samba.org>
Date: Wed, 30 Mar 2011 04:57:05 +0000 (+0200)
Subject: s3: Fix Coverity ID 2236: REVERSE_INULL
X-Git-Tag: ldb-1.1.0~373
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8486f0fa0495e51d204dca970bf864041123b631;p=thirdparty%2Fsamba.git

s3: Fix Coverity ID 2236: REVERSE_INULL

We have already dereferenced "b", and the other calls in this loop can only
have worked with a valid handle
---

diff --git a/source3/smbd/lanman.c b/source3/smbd/lanman.c
index bf2987f9077..a04f0622747 100644
--- a/source3/smbd/lanman.c
+++ b/source3/smbd/lanman.c
@@ -1148,9 +1148,7 @@ static bool api_DosPrintQEnum(struct smbd_server_connection *sconn,
 		subcntarr[i] = num_jobs;
 		subcnt += subcntarr[i];
 
-		if (b && is_valid_policy_hnd(&handle)) {
-			dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr);
-		}
+		dcerpc_spoolss_ClosePrinter(b, mem_ctx, &handle, &werr);
 	}
 
 	if (init_package(&desc,queuecnt,subcnt)) {