From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 10 Aug 2023 04:13:12 +0000 (+1200)
Subject: s4:kdc: Return an error code if sdb_entry_to_hdb_entry() fails
X-Git-Tag: tevent-0.16.0~999
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84929c6855cb2c243e04eea7276ec96e14bcad9a;p=thirdparty%2Fsamba.git

s4:kdc: Return an error code if sdb_entry_to_hdb_entry() fails

This condition was written backwards — if samba_kdc_fetch() returned
zero, we would ignore any error code returned by
sdb_entry_to_hdb_entry().

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/hdb-samba4.c b/source4/kdc/hdb-samba4.c
index efe2f5316d9..b6c7b2a4bba 100644
--- a/source4/kdc/hdb-samba4.c
+++ b/source4/kdc/hdb-samba4.c
@@ -178,7 +178,7 @@ static krb5_error_code hdb_samba4_fetch_kvno(krb5_context context, HDB *db,
 	ret = sdb_entry_to_hdb_entry(context, &sentry, entry);
 	sdb_entry_free(&sentry);
 
-	if (code != 0 && ret != 0) {
+	if (code == 0) {
 		code = ret;
 	}