From: Thomas Markwalder <tmark@isc.org>
Date: Mon, 4 Apr 2016 11:16:09 +0000 (-0400)
Subject: [4259] Add unit tests to ensure StringParser can parse booleans
X-Git-Tag: trac4106_update_base~48^2~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=849439da6c8b70c61e69dc7b3c153b13a8a77d0b;p=thirdparty%2Fkea.git

[4259] Add unit tests to ensure StringParser can parse booleans

    Added checks to ensure that StringParser can handle being given
    a boolean literal (i.e. unquoted true or false)
---

diff --git a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
index dc93e5101f..2c57c9082e 100644
--- a/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
+++ b/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
@@ -144,6 +144,24 @@ TEST_F(DhcpParserTest, stringParserTest) {
     parser.commit();
     EXPECT_NO_THROW((actual_value = storage->getParam(name)));
     EXPECT_EQ(test_value, actual_value);
+
+    // Verify that parser with accepts a boolean true element.
+    element = Element::create(true);
+    EXPECT_NO_THROW(parser.build(element));
+
+    // Verify that commit updates storage.
+    parser.commit();
+    EXPECT_NO_THROW((actual_value = storage->getParam(name)));
+    EXPECT_EQ("true", actual_value);
+
+    // Verify that parser with accepts a boolean true element.
+    element = Element::create(false);
+    EXPECT_NO_THROW(parser.build(element));
+
+    // Verify that commit updates storage.
+    parser.commit();
+    EXPECT_NO_THROW((actual_value = storage->getParam(name)));
+    EXPECT_EQ("false", actual_value);
 }
 
 /// @brief Check Uint32Parser basic functionality