From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 7 Feb 2025 15:10:59 +0000 (+0100)
Subject: winbindd: assert that wbint_binding_handle() gets a valid memory context
X-Git-Tag: tevent-0.17.0~844
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84aa2c21213eb1e61807214968389ae6abefd6f0;p=thirdparty%2Fsamba.git

winbindd: assert that wbint_binding_handle() gets a valid memory context

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/winbindd/winbindd_dual_ndr.c b/source3/winbindd/winbindd_dual_ndr.c
index 219596b9fc0..2d452385572 100644
--- a/source3/winbindd/winbindd_dual_ndr.c
+++ b/source3/winbindd/winbindd_dual_ndr.c
@@ -38,7 +38,7 @@
 #include "lib/tsocket/tsocket.h"
 
 struct wbint_bh_state {
-	struct winbindd_domain *domain;
+	struct winbindd_domain *domain; /* if valid also talloc (grant) parent */
 	struct winbindd_child *child;
 	const struct dcerpc_binding *binding;
 };
@@ -518,6 +518,8 @@ struct dcerpc_binding_handle *wbint_binding_handle(TALLOC_CTX *mem_ctx,
 	struct dcerpc_binding *b = NULL;
 	NTSTATUS status;
 
+	SMB_ASSERT(mem_ctx != NULL);
+
 	SMB_ASSERT((domain != NULL && child == NULL) ||
 		  (domain == NULL && child != NULL));