From: Tim Wiederhake <twiederh@redhat.com>
Date: Wed, 14 Jul 2021 08:49:23 +0000 (+0200)
Subject: virNWFilterParseParamAttributes: Use automatic memory management
X-Git-Tag: v7.6.0-rc1~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84ac5beeac73002515025fce56f845cac79aa9d3;p=thirdparty%2Flibvirt.git

virNWFilterParseParamAttributes: Use automatic memory management

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c
index 0b967e1194..0b1676e25f 100644
--- a/src/conf/nwfilter_params.c
+++ b/src/conf/nwfilter_params.c
@@ -698,18 +698,15 @@ virNWFilterParseVarValue(const char *val)
 GHashTable *
 virNWFilterParseParamAttributes(xmlNodePtr cur)
 {
-    char *nam, *val;
-    virNWFilterVarValue *value;
-
-    GHashTable *table = virHashNew(virNWFilterVarValueHashFree);
+    g_autoptr(GHashTable) table = virHashNew(virNWFilterVarValueHashFree);
 
     cur = xmlFirstElementChild(cur);
 
     while (cur != NULL) {
         if (virXMLNodeNameEqual(cur, "parameter")) {
-            nam = virXMLPropString(cur, "name");
-            val = virXMLPropString(cur, "value");
-            value = NULL;
+            g_autofree char *nam = virXMLPropString(cur, "name");
+            g_autofree char *val = virXMLPropString(cur, "value");
+            g_autoptr(virNWFilterVarValue) value = NULL;
             if (nam != NULL && val != NULL) {
                 if (!isValidVarName(nam))
                     goto skip_entry;
@@ -733,20 +730,13 @@ virNWFilterParseParamAttributes(xmlNodePtr cur)
                 value = NULL;
             }
  skip_entry:
-            virNWFilterVarValueFree(value);
-            VIR_FREE(nam);
-            VIR_FREE(val);
         }
-
         cur = xmlNextElementSibling(cur);
     }
-    return table;
+
+    return g_steal_pointer(&table);
 
  err_exit:
-    VIR_FREE(nam);
-    VIR_FREE(val);
-    virNWFilterVarValueFree(value);
-    virHashFree(table);
     return NULL;
 }