From: Ralf Habacker <ralf.habacker@freenet.de>
Date: Tue, 5 May 2015 15:10:01 +0000 (+0200)
Subject: auth_set_unix_credentials: Fix calling _dbus_credentials_add_pid without checking... 
X-Git-Tag: dbus-1.9.16~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84b2682eef49a247d15492d8bf826232e41d3216;p=thirdparty%2Fdbus.git

auth_set_unix_credentials: Fix calling _dbus_credentials_add_pid without checking return value (CID 54708).

Reported by Coverity: CID 54708: Unchecked return value (CHECKED_RETURN)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
---

diff --git a/dbus/dbus-auth-script.c b/dbus/dbus-auth-script.c
index fdbe1fe48..738722037 100644
--- a/dbus/dbus-auth-script.c
+++ b/dbus/dbus-auth-script.c
@@ -226,8 +226,10 @@ auth_set_unix_credentials(DBusAuth  *auth,
         _dbus_assert_not_reached ("no memory");
     }
   if (pid != DBUS_PID_UNSET)
-    _dbus_credentials_add_pid (credentials, pid);
-
+    {
+      if (!_dbus_credentials_add_pid (credentials, pid))
+        _dbus_assert_not_reached ("no memory");
+    }
   _dbus_auth_set_credentials (auth, credentials);
 
   _dbus_credentials_unref (credentials);