From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 23 Dec 2021 21:53:13 +0000 (+0100)
Subject: s4:auth: debug make_user_info_dc_pac() failures in kerberos_pac_to_user_info_dc()
X-Git-Tag: tdb-1.4.6~74
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84b76270ceb38cbb0263f415f4089bafa751b3a3;p=thirdparty%2Fsamba.git

s4:auth: debug make_user_info_dc_pac() failures in kerberos_pac_to_user_info_dc()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Joseph Sutton <josephsutton@catalyst.net.nz>
---

diff --git a/source4/auth/kerberos/kerberos_pac.c b/source4/auth/kerberos/kerberos_pac.c
index 54ef4d61b02..dccf165384e 100644
--- a/source4/auth/kerberos/kerberos_pac.c
+++ b/source4/auth/kerberos/kerberos_pac.c
@@ -300,7 +300,7 @@ krb5_error_code kerberos_pac_to_user_info_dc(TALLOC_CTX *mem_ctx,
 
 	union PAC_INFO info;
 	union PAC_INFO _upn_dns_info;
-	const struct PAC_UPN_DNS_INFO *upn_dns_info = NULL;
+	struct PAC_UPN_DNS_INFO *upn_dns_info = NULL;
 	struct auth_user_info_dc *user_info_dc_out;
 
 	TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
@@ -369,6 +369,12 @@ krb5_error_code kerberos_pac_to_user_info_dc(TALLOC_CTX *mem_ctx,
 					 upn_dns_info,
 					 &user_info_dc_out);
 	if (!NT_STATUS_IS_OK(nt_status)) {
+		DBG_ERR("make_user_info_dc_pac() failed -%s\n",
+			nt_errstr(nt_status));
+		NDR_PRINT_DEBUG(PAC_LOGON_INFO, info.logon_info.info);
+		if (upn_dns_info != NULL) {
+			NDR_PRINT_DEBUG(PAC_UPN_DNS_INFO, upn_dns_info);
+		}
 		talloc_free(tmp_ctx);
 		return EINVAL;
 	}