From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 11 Aug 2009 21:45:01 +0000 (-0400)
Subject: Fix crash/warning bug when we get an unexpected close.
X-Git-Tag: tor-0.2.3.1-alpha~362^2~16
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84bb5d573c7b067821debc62538dfb99aa44fd53;p=thirdparty%2Ftor.git

Fix crash/warning bug when we get an unexpected close.

This was possible if we have already decided to close a bufferevent
connection, but the other side decides to close it first.
---

diff --git a/src/or/connection.c b/src/or/connection.c
index 8b9d47d5d1..24fc9f206b 100644
--- a/src/or/connection.c
+++ b/src/or/connection.c
@@ -700,10 +700,9 @@ connection_close_immediate(connection_t *conn)
   conn->s = -1;
   if (conn->linked)
     conn->linked_conn_is_closed = 1;
-  if (!connection_is_listener(conn)) {
+  if (conn->outbuf)
     buf_clear(conn->outbuf);
-    conn->outbuf_flushlen = 0;
-  }
+  conn->outbuf_flushlen = 0;
 }
 
 /** Mark <b>conn</b> to be closed next time we loop through
@@ -2721,12 +2720,14 @@ connection_handle_event_cb(struct bufferevent *bufev, short event, void *arg)
                                    tor_socket_strerror(socket_error));
     } else if (CONN_IS_EDGE(conn)) {
       edge_connection_t *edge_conn = TO_EDGE_CONN(conn);
-      connection_edge_end_errno(edge_conn);
+      if (!edge_conn->edge_has_sent_end)
+        connection_edge_end_errno(edge_conn);
       if (edge_conn->socks_request) /* broken, don't send a socks reply back */
         edge_conn->socks_request->has_finished = 1;
     }
     connection_close_immediate(conn); /* Connection is dead. */
-    connection_mark_for_close(conn);
+    if (!conn->marked_for_close)
+      connection_mark_for_close(conn);
   }
 }