From: Simone Weiß Date: Wed, 14 Feb 2024 19:03:02 +0000 (+0000) Subject: patchtest: log errors and failures at end X-Git-Tag: uninative-4.4~124 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84ca5a5f5a44de6ed4551ab08e58087aaa7e1369;p=thirdparty%2Fopenembedded%2Fopenembedded-core.git patchtest: log errors and failures at end At the moment, running patchtest locally will only print failures and errors to the log when the not passing test case is executed. This might lead to people overlooking issues with their patches, so print a log line at the end if testcases showed issues. This should make it more easy to spot then before. Fixes [YOCTO #15389] Signed-off-by: Simone Weiß Signed-off-by: Richard Purdie --- diff --git a/scripts/patchtest b/scripts/patchtest index a1c824f7b7c..8c9a73e1dba 100755 --- a/scripts/patchtest +++ b/scripts/patchtest @@ -142,6 +142,8 @@ def _runner(resultklass, prefix=None): logger.error(traceback.print_exc()) logger.error('patchtest: something went wrong') return 1 + if result.test_failure or result.test_error: + return 1 return 0 @@ -158,9 +160,14 @@ def run(patch, logfile=None): postmerge_resultklass = getResult(patch, True, logfile) postmerge_result = _runner(postmerge_resultklass, 'test') + print('----------------------------------------------------------------------\n') if premerge_result == 2 and postmerge_result == 2: - logger.error('patchtest: any test cases found - did you specify the correct suite directory?') - + logger.error('patchtest: Not any test cases found - did you specify the correct suite directory?') + if premerge_result == 1 or postmerge_result == 1: + logger.error('patchtest: At least one patchtest caused a failure or an error - please check') + else: + logger.error('patchtest: All patchtests passed') + print('----------------------------------------------------------------------\n') return premerge_result or postmerge_result def main():