From: Joseph Sutton Date: Tue, 29 Aug 2023 08:48:14 +0000 (+1200) Subject: buildtools: Properly set global variable X-Git-Tag: tevent-0.16.0~786 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84dc7129ead1c80b89f89f7d5b426ea3592fca58;p=thirdparty%2Fsamba.git buildtools: Properly set global variable Since we didn’t declare ‘old_refill_task_list’ as global, we were just assigning a value to a local variable that was destroyed after we returned from this function. We clearly intended instead to assign to a global variable of the same name. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- diff --git a/buildtools/wafsamba/stale_files.py b/buildtools/wafsamba/stale_files.py index 78efea424fd..ac2c2a74194 100644 --- a/buildtools/wafsamba/stale_files.py +++ b/buildtools/wafsamba/stale_files.py @@ -107,6 +107,7 @@ def replace_refill_task_list(self): def AUTOCLEANUP_STALE_FILES(bld): """automatically clean up any files in bin that shouldn't be there""" + global old_refill_task_list old_refill_task_list = Parallel.refill_task_list Parallel.refill_task_list = replace_refill_task_list Parallel.bld = bld