From: Richard Biener <rguenther@suse.de>
Date: Mon, 5 Jun 2023 06:56:53 +0000 (+0200)
Subject: middle-end/110055 - avoid CLOBBERing static variables
X-Git-Tag: basepoints/gcc-15~8577
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84eec2916fa68cd2e2b3a2cf764f2ba595cce843;p=thirdparty%2Fgcc.git

middle-end/110055 - avoid CLOBBERing static variables

The gimplifier can elide initialized constant automatic variables
to static storage in which case TARGET_EXPR gimplification needs
to avoid emitting a CLOBBER for them since their lifetime is no
longer limited.  Failing to do so causes spurious dangling-pointer
diagnostics on the added testcase for some targets.

	PR middle-end/110055
	* gimplify.cc (gimplify_target_expr): Do not emit
	CLOBBERs for variables which have static storage duration
	after gimplifying their initializers.

	* g++.dg/warn/Wdangling-pointer-pr110055.C: New testcase.
---

diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc
index bd5d0bf2bd8f..4aa6229fc745 100644
--- a/gcc/gimplify.cc
+++ b/gcc/gimplify.cc
@@ -7174,8 +7174,10 @@ gimplify_target_expr (tree *expr_p, gimple_seq *pre_p, gimple_seq *post_p)
 	gimplify_and_add (init, &init_pre_p);
 
       /* Add a clobber for the temporary going out of scope, like
-	 gimplify_bind_expr.  */
+	 gimplify_bind_expr.  But only if we did not promote the
+	 temporary to static storage.  */
       if (gimplify_ctxp->in_cleanup_point_expr
+	  && !TREE_STATIC (temp)
 	  && needs_to_live_in_memory (temp))
 	{
 	  if (flag_stack_reuse == SR_ALL)
diff --git a/gcc/testsuite/g++.dg/warn/Wdangling-pointer-pr110055.C b/gcc/testsuite/g++.dg/warn/Wdangling-pointer-pr110055.C
new file mode 100644
index 000000000000..77dbbf380b69
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wdangling-pointer-pr110055.C
@@ -0,0 +1,16 @@
+// { dg-do compile }
+// { dg-require-effective-target c++11 }
+// { dg-options "-O3 -fno-exceptions -Wdangling-pointer" }
+
+#include <cstdint>
+#include <vector>
+
+struct Data {
+  std::vector<uint16_t> v = {1, 1};
+};
+
+int main()
+{
+  Data a;
+  Data b;
+}