From: Francesco Chemolli <kinkie@squid-cache.org>
Date: Thu, 10 Jul 2008 18:08:51 +0000 (+0200)
Subject: Some more caller refactoring
X-Git-Tag: SQUID_3_1_0_1~49^2~143^2~23
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84f5078704d0e0ad77e092f406dc2c4e2a1214cb;p=thirdparty%2Fsquid.git

Some more caller refactoring
---

diff --git a/src/Mem.h b/src/Mem.h
index ec2ae8c91d..032c364ad5 100644
--- a/src/Mem.h
+++ b/src/Mem.h
@@ -48,7 +48,7 @@ class Mem
 public:
     static void Init();
     static void Report();
-    static void RegisterWithCacheManager(CacheManager & manager);
+    static void RegisterWithCacheManager(void);
     static void Stats(StoreEntry *);
     static void CleanIdlePools(void *unused);
     static void Report(std::ostream &);
diff --git a/src/forward.cc b/src/forward.cc
index 4daef3197c..83aabb8d6b 100644
--- a/src/forward.cc
+++ b/src/forward.cc
@@ -1180,11 +1180,10 @@ FwdState::initModule()
 }
 
 void
-FwdState::RegisterWithCacheManager(CacheManager & manager)
+FwdState::RegisterWithCacheManager(void)
 {
-    manager.registerAction("forward",
-                           "Request Forwarding Statistics",
-                           fwdStats, 0, 1);
+    CacheManager::GetInstance()->
+         registerAction("forward", "Request Forwarding Statistics", fwdStats, 0, 1);
 }
 
 void
diff --git a/src/forward.h b/src/forward.h
index bec382078e..5124d4ee52 100644
--- a/src/forward.h
+++ b/src/forward.h
@@ -25,7 +25,7 @@ public:
     typedef RefCount<FwdState> Pointer;
     ~FwdState();
     static void initModule();
-    static void RegisterWithCacheManager(CacheManager & manager);
+    static void RegisterWithCacheManager(void);
 
     static void fwdStart(int fd, StoreEntry *, HttpRequest *);
     void startComplete(FwdServer *);
diff --git a/src/main.cc b/src/main.cc
index c638532c8c..c6467fca3b 100644
--- a/src/main.cc
+++ b/src/main.cc
@@ -128,8 +128,6 @@ static void SquidShutdown(void);
 static void mainSetCwd(void);
 static int checkRunningPid(void);
 
-static CacheManager *manager=CacheManager::GetInstance();
-
 #ifndef _SQUID_MSWIN_
 static const char *squid_start_script = "squid_start";
 #endif
@@ -138,6 +136,8 @@ static const char *squid_start_script = "squid_start";
 #include "test_access.c"
 #endif
 
+static CacheManager *manager=CacheManager::GetInstance();
+
 /** temporary thunk across to the unrefactored store interface */
 
 class StoreRootEngine : public AsyncEngine
@@ -1011,7 +1011,7 @@ mainInitialize(void)
         eventInit();
         externalAclRegisterWithCacheManager();
         fqdncacheRegisterWithCacheManager();
-        FwdState::RegisterWithCacheManager(*manager);
+        FwdState::RegisterWithCacheManager();
         httpHeaderRegisterWithCacheManager();
 #if !USE_DNSSERVERS
 
@@ -1019,7 +1019,7 @@ mainInitialize(void)
 #endif
 
         ipcacheRegisterWithCacheManager();
-        Mem::RegisterWithCacheManager(*manager);
+        Mem::RegisterWithCacheManager();
         netdbRegisterWitHCacheManager();
         PconnModule::GetInstance()->registerWithCacheManager();
         redirectRegisterWithCacheManager();
diff --git a/src/mem.cc b/src/mem.cc
index 9f0bce2d3d..3cc0b59f53 100644
--- a/src/mem.cc
+++ b/src/mem.cc
@@ -440,10 +440,9 @@ Mem::Report()
 }
 
 void
-Mem::RegisterWithCacheManager(CacheManager & manager)
+Mem::RegisterWithCacheManager(void)
 {
-    manager.registerAction("mem",
-                           "Memory Utilization",
+    CacheManager::GetInstance()->registerAction("mem", "Memory Utilization",
                            Mem::Stats, 0, 1);
 }