From: Bob Halley <halley@dnspython.org>
Date: Sat, 7 Apr 2012 20:43:32 +0000 (+0100)
Subject: raise ValueError if the argument to node.replace_rdataset() is not an rdataset
X-Git-Tag: v1.10.0~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=84fd7372b00afa4c55d4b32ca1d6f0c5a35b77df;p=thirdparty%2Fdnspython.git

raise ValueError if the argument to node.replace_rdataset() is not an rdataset
---

diff --git a/dns/node.py b/dns/node.py
index 7625c66d..f480610a 100644
--- a/dns/node.py
+++ b/dns/node.py
@@ -167,6 +167,8 @@ class Node(object):
         at the node, it stores I{replacement} itself.
         """
 
+        if not isinstance(replacement, dns.rdataset.Rdataset):
+            raise ValueError, 'replacement is not an rdataset'
         self.delete_rdataset(replacement.rdclass, replacement.rdtype,
                              replacement.covers)
         self.rdatasets.append(replacement)