From: Stefan Metzmacher <metze@samba.org>
Date: Wed, 29 Jan 2025 10:34:42 +0000 (+0100)
Subject: s4:auth: simplify auth_anonymous_user_info_dc()
X-Git-Tag: tevent-0.17.0~775
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=850e030d8e15b018076f32c5bd311a50dcde70a6;p=thirdparty%2Fsamba.git

s4:auth: simplify auth_anonymous_user_info_dc()

By using (struct auth_SidAttr) {} we don't leave
uninitialized memory if struct auth_SidAttr changes.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
---

diff --git a/source4/auth/system_session.c b/source4/auth/system_session.c
index 1682339a8f4..8b4b65f3cd4 100644
--- a/source4/auth/system_session.c
+++ b/source4/auth/system_session.c
@@ -483,8 +483,10 @@ _PUBLIC_ NTSTATUS auth_anonymous_user_info_dc(TALLOC_CTX *mem_ctx,
 		return NT_STATUS_NO_MEMORY;
 	};
 
-	user_info_dc->sids->sid = global_sid_Anonymous;
-	user_info_dc->sids->attrs = SE_GROUP_DEFAULT_FLAGS;
+	user_info_dc->sids[0] = (struct auth_SidAttr) {
+		.sid = global_sid_Anonymous,
+		.attrs = SE_GROUP_DEFAULT_FLAGS,
+	};
 
 	/* annoying, but the Anonymous really does have a session key... */
 	user_info_dc->user_session_key = data_blob_talloc(user_info_dc, NULL, 16);