From: Eric Wong <e@80x24.org>
Date: Sat, 25 Nov 2023 20:54:35 +0000 (+0000)
Subject: ds: long_step: eliminate redundant fileno call
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8517e1fc5ec052719920c11c6babce2a395c48a9;p=thirdparty%2Fpublic-inbox.git

ds: long_step: eliminate redundant fileno call

We already stash the associated FD for reporting at startup and
don't need to call `fileno' again.  Found via manual code
inspection while considering the effort to make async {forward}
from PublicInbox::HTTP more like the generic long_response API
and {long_cb} field used by IMAP/NNTP/POP3.
---

diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index 4c8b502f4..8bc8cfb77 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -629,7 +629,6 @@ sub long_step {
 		delete $self->{long_cb};
 		$self->long_response_done;
 		my $elapsed = now() - $t0;
-		my $fd = fileno($self->{sock});
 		$self->out(" deferred[$fd] done - %0.6f", $elapsed);
 		my $wbuf = $self->{wbuf}; # do NOT autovivify
 		requeue($self) unless $wbuf && @$wbuf;