From: hn <hn@users.noreply.github.com>
Date: Mon, 7 Jan 2019 18:42:02 +0000 (+0100)
Subject: fix: unprivileged veth devices (e.g. vethFWABHX) never contain 'Z' character in the... 
X-Git-Tag: lxc-3.2.0~195^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8523344a390f6e6c6707358b84f27ab59a891b2c;p=thirdparty%2Flxc.git

fix: unprivileged veth devices (e.g. vethFWABHX) never contain 'Z' character in the randomly generated device name part because for modulo one does not need to substract 1 from strlen().

Signed-off-by: Hajo Noerenberg <hajo-github@noerenberg.de>
---

diff --git a/src/lxc/network.c b/src/lxc/network.c
index d0f14e632..499ddff6e 100644
--- a/src/lxc/network.c
+++ b/src/lxc/network.c
@@ -1982,9 +1982,9 @@ char *lxc_mkifname(char *template)
 		for (i = 0; i < strlen(name); i++) {
 			if (name[i] == 'X') {
 #ifdef HAVE_RAND_R
-				name[i] = padchar[rand_r(&seed) % (strlen(padchar) - 1)];
+				name[i] = padchar[rand_r(&seed) % strlen(padchar)];
 #else
-				name[i] = padchar[rand() % (strlen(padchar) - 1)];
+				name[i] = padchar[rand() % strlen(padchar)];
 #endif
 			}
 		}