From: Phil Sutter <phil@nwl.cc>
Date: Thu, 17 Aug 2017 17:09:25 +0000 (+0200)
Subject: devlink: No need for this self-assignment
X-Git-Tag: v4.13.0~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8579a398c5ab0d26bce0ed9b4b6b6e5d62fcc89d;p=thirdparty%2Fiproute2.git

devlink: No need for this self-assignment

dl_argv_handle_both() will either assign to handle_bit or error out in
which case the variable is not used by the caller.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Jiri Pirko <jiri@mellanox.com>
---

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 7602970bc..5b325ce6c 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -779,7 +779,7 @@ static int dl_argv_parse(struct dl *dl, uint32_t o_required,
 	int err;
 
 	if (o_required & DL_OPT_HANDLE && o_required & DL_OPT_HANDLEP) {
-		uint32_t handle_bit = handle_bit;
+		uint32_t handle_bit;
 
 		err = dl_argv_handle_both(dl, &opts->bus_name, &opts->dev_name,
 					  &opts->port_index, &handle_bit);