From: Francis Dupont <fdupont@isc.org>
Date: Thu, 5 Nov 2015 00:58:13 +0000 (+0100)
Subject: [4091] Better odd check
X-Git-Tag: trac4115_base~2^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85a118414f505a761bbb875ec9eb54aa4e63c0c6;p=thirdparty%2Fkea.git

[4091] Better odd check
---

diff --git a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
index 462945f88f..d39763d91e 100644
--- a/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
+++ b/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
@@ -593,7 +593,7 @@ OptionDataParser::createOption(ConstElementPtr option_data) {
             // The decodeHex function expects that the string contains an
             // even number of digits. If we don't meet this requirement,
             // we have to insert a leading 0.
-            if (!data_param.empty() && data_param.length() % 2) {
+            if (!data_param.empty() && ((data_param.length() % 2) != 0)) {
                 data_param = data_param.insert(0, "0");
             }
             util::encode::decodeHex(data_param, binary);
diff --git a/src/lib/eval/token.cc b/src/lib/eval/token.cc
index 63aa7b7c8f..3592ffad35 100644
--- a/src/lib/eval/token.cc
+++ b/src/lib/eval/token.cc
@@ -41,7 +41,7 @@ TokenHexString::evaluate(const Pkt& /*pkt*/, ValueStack& values) {
         // The decodeHex function expects that the string contains an
         // even number of digits. If we don't meet this requirement,
         // we have to insert a leading 0.
-        if (repr_.length() % 2) {
+        if ((repr_.length() % 2) != 0) {
             repr_ = repr_.insert(0, "0");
         }
         util::encode::decodeHex(repr_, binary);