From: Michael Brown <mcb30@ipxe.org>
Date: Wed, 15 Sep 2010 03:56:28 +0000 (+0100)
Subject: [netdevice] Report network-layer errors via network device statistics
X-Git-Tag: v1.20.1~2528
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85a3169967350fb92548a3e50ec7c533b27f407b;p=thirdparty%2Fipxe.git

[netdevice] Report network-layer errors via network device statistics

Errors generated by the network layer in response to received packets
are liable to be lost, since nothing systematically records these
errors and often the packets do not propagate far enough through the
stack to impact upon user-visible processes.

Improve this situation by recording network-layer errors in the
network device statistics.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/net/netdevice.c b/src/net/netdevice.c
index 51bd344b2..bb8a5b281 100644
--- a/src/net/netdevice.c
+++ b/src/net/netdevice.c
@@ -658,7 +658,7 @@ int net_rx ( struct io_buffer *iobuf, struct net_device *netdev,
 	DBGC ( netdev, "NETDEV %p unknown network protocol %04x\n",
 	       netdev, ntohs ( net_proto ) );
 	free_iob ( iobuf );
-	return 0;
+	return -ENOTSUP;
 }
 
 /**
@@ -705,7 +705,12 @@ static void net_step ( struct process *process __unused ) {
 				continue;
 			}
 
-			net_rx ( iobuf, netdev, net_proto, ll_source );
+			/* Hand packet to network layer */
+			if ( ( rc = net_rx ( iob_disown ( iobuf ), netdev,
+					     net_proto, ll_source ) ) != 0 ) {
+				/* Record error for diagnosis */
+				netdev_rx_err ( netdev, NULL, rc );
+			}
 		}
 	}
 }