From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 17 Sep 2025 07:35:54 +0000 (+0200)
Subject: pcrextend: add documentation for varlink api
X-Git-Tag: v259-rc1~556
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85a725a9428d15548925ff482ec402f61cef812e;p=thirdparty%2Fsystemd.git

pcrextend: add documentation for varlink api
---

diff --git a/TODO b/TODO
index 58edfc13169..0aa861c9188 100644
--- a/TODO
+++ b/TODO
@@ -245,7 +245,6 @@ Features:
   - io.systemd.Hostname
   - io.systemd.ManagedOOM
   - io.systemd.Network
-  - io.systemd.PCRExtend
   - io.systemd.PCRLock
   - io.systemd.Resolve.Monitor
   - io.systemd.Resolve
diff --git a/src/shared/varlink-io.systemd.PCRExtend.c b/src/shared/varlink-io.systemd.PCRExtend.c
index 956a0eacca7..d104fc0853b 100644
--- a/src/shared/varlink-io.systemd.PCRExtend.c
+++ b/src/shared/varlink-io.systemd.PCRExtend.c
@@ -4,11 +4,16 @@
 
 static SD_VARLINK_DEFINE_METHOD(
                 Extend,
+                SD_VARLINK_FIELD_COMMENT("PCR number to extend, in range of 0…23"),
                 SD_VARLINK_DEFINE_INPUT(pcr, SD_VARLINK_INT, 0),
+                SD_VARLINK_FIELD_COMMENT("Text string to measure. (Specify either this, or the 'data' field below, not both)"),
                 SD_VARLINK_DEFINE_INPUT(text, SD_VARLINK_STRING, SD_VARLINK_NULLABLE),
+                SD_VARLINK_FIELD_COMMENT("Binary data to measure, encoded in Base64. (Specify either this, or the 'text' field above, not both)"),
                 SD_VARLINK_DEFINE_INPUT(data, SD_VARLINK_STRING, SD_VARLINK_NULLABLE));
 
 SD_VARLINK_DEFINE_INTERFACE(
                 io_systemd_PCRExtend,
                 "io.systemd.PCRExtend",
+                SD_VARLINK_INTERFACE_COMMENT("TPM PCR Extension APIs"),
+                SD_VARLINK_SYMBOL_COMMENT("Measure some text or binary data into a PCR"),
                 &vl_method_Extend);