From: Mark Michelson <mmichelson@digium.com>
Date: Sat, 2 May 2009 10:21:00 +0000 (+0000)
Subject: Move static buffers to outside for loops in app_chanspy.
X-Git-Tag: 1.4.25-rc1~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85a89165526e2e0afaebb7e15de52138a024cad0;p=thirdparty%2Fasterisk.git

Move static buffers to outside for loops in app_chanspy.

Similar to seanbright's commit 191422, this moves some static buffers
to be defined outside of for loops since it is undefined if memory
will be re-used or if the stack will grow with each iteration of the
loop.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@191628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/apps/app_chanspy.c b/apps/app_chanspy.c
index 18e4972a5e..c4c3718cd9 100644
--- a/apps/app_chanspy.c
+++ b/apps/app_chanspy.c
@@ -508,6 +508,8 @@ static int common_exec(struct ast_channel *chan, const struct ast_flags *flags,
 	char nameprefix[AST_NAME_STRLEN];
 	char peer_name[AST_NAME_STRLEN + 5];
 	signed char zero_volume = 0;
+	char *groups[25];
+	char dup_group[512];
 	int waitms;
 	int res;
 	char *ptr;
@@ -557,9 +559,7 @@ static int common_exec(struct ast_channel *chan, const struct ast_flags *flags,
 			 	next_channel(chan, prev, spec, exten, context, &chanspy_ds), next_chanspy_ds = NULL) {
 			const char *group;
 			int igrp = !mygroup;
-			char *groups[25];
 			int num_groups = 0;
-			char dup_group[512];
 			int x;
 			char *s;