From: Patrick McHardy <kaber@trash.net>
Date: Wed, 2 Feb 2011 19:40:12 +0000 (+0100)
Subject: netfilter: ipset: add missing break statemtns in ip_set_get_ip_port()
X-Git-Tag: v6.0~5
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85cee26417bb1456575028fdfe343b3db777a5c9;p=thirdparty%2Fipset.git

netfilter: ipset: add missing break statemtns in ip_set_get_ip_port()

Don't fall through in the switch statement, otherwise IPv4 headers
are incorrectly parsed again as IPv6 and the return value will always
be 'false'.

Signed-off-by: Patrick McHardy <kaber@trash.net>
---

diff --git a/kernel/ip_set_getport.c b/kernel/ip_set_getport.c
index 76737bba..4dd2785a 100644
--- a/kernel/ip_set_getport.c
+++ b/kernel/ip_set_getport.c
@@ -118,8 +118,10 @@ ip_set_get_ip_port(const struct sk_buff *skb, u8 pf, bool src, __be16 *port)
 	switch (pf) {
 	case AF_INET:
 		ret = ip_set_get_ip4_port(skb, src, port, &proto);
+		break;
 	case AF_INET6:
 		ret = ip_set_get_ip6_port(skb, src, port, &proto);
+		break;
 	default:
 		return false;
 	}