From: William A. Rowe Jr <wrowe@apache.org>
Date: Fri, 9 Jan 2009 21:28:52 +0000 (+0000)
Subject: toss up a silly idea that would make rotatelogs as painless as the
X-Git-Tag: 2.0.64~105
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85e0bf1860ca3df3cc2e68a827e335c3b9800c61;p=thirdparty%2Fapache%2Fhttpd.git

toss up a silly idea that would make rotatelogs as painless as the
core logging logic, vote a patch and bump a patch up to accepted.

Not that 2.0.64 will be here anytime soon, but w.t.h. - who knows
when we'll have a real reason to just go and toss out a release?


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.0.x@733156 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/STATUS b/STATUS
index 6f5d42ccfe2..a58d9cb7708 100644
--- a/STATUS
+++ b/STATUS
@@ -117,6 +117,13 @@ RELEASE SHOWSTOPPERS:
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
   [ start all new proposals below, under PATCHES PROPOSED. ]
 
+  * Backport 164538: add ap_vhost_iterate_given_conn().
+    Trunk version of patch:
+       http://svn.apache.org/viewvc?view=rev&revision=164538
+    Backport version for 2.0.x of patch:
+       http://people.apache.org/~fuankg/diffs/httpd-2.0.x-ap_vhost_iterate_given_conn.diff
+    +1: fuankg, wrowe, pgollucci
+
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ please place SVN revisions from trunk here, so it is easy to
     identify exactly what the proposed changes are!  Add all new
@@ -131,13 +138,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
           do we need to make people opt-in for this behavior to 
           backport it to 2.0.x? What mechanism?
 
-  * Backport 164538: add ap_vhost_iterate_given_conn().
-    Trunk version of patch:
-       http://svn.apache.org/viewvc?view=rev&revision=164538
-    Backport version for 2.0.x of patch:
-       http://people.apache.org/~fuankg/diffs/httpd-2.0.x-ap_vhost_iterate_given_conn.diff
-    +1: fuankg, wrowe, pgollucci
-
   * Backport 354118: Fix recursive ErrorDocument handling [when r->status isn't
     HTTP_OK upon first pass through ap_die()]. PR #36090
     Trunk version of patch:
@@ -150,7 +150,23 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
     list of headers allowed to pass through on a 304 response.
     This has been in trunk since 2004, released in 2.2.0.
       http://svn.apache.org/viewvc?view=rev&revision=104924
-    +1: fielding
+    +1: fielding, wrowe
+
+  * Stupid-simple patch specific to give rotatelogs the same behavior
+    as the core log writer;
+    +1: wrowe
+--- support/rotatelogs.c	(revision 733150)
++++ support/rotatelogs.c	(working copy)
+@@ -208,7 +208,8 @@
+                 sprintf(buf2, "%s.%010d", szLogRoot, tLogStart);
+             }
+             tLogEnd = tLogStart + tRotation;
+-            apr_file_open(&nLogFD, buf2, APR_READ | APR_WRITE | APR_CREATE | APR_APPEND,
++            apr_file_open(&nLogFD, buf2, 
++                          APR_APPEND | APR_WRITE | APR_CREATE | APR_LARGEFILE,
+                           APR_OS_DEFAULT, pool);
+             if (nLogFD == NULL) {
+                 /* Uh-oh. Failed to open the new log file. Try to clear
 
 
 PATCHES TO BACKPORT THAT ARE ON HOLD OR NOT GOING ANYWHERE SOON: