From: Volker Lendecke <vl@samba.org>
Date: Tue, 9 Oct 2018 19:41:52 +0000 (+0200)
Subject: gencache: Remove a redundant check
X-Git-Tag: tdb-1.3.17~1297
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85ec8644251eff0174c973747b59043180ac58c7;p=thirdparty%2Fsamba.git

gencache: Remove a redundant check

tdb_storev itself is robust against overflow due to multiple buffers

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Oct 17 22:22:51 CEST 2018 on sn-devel-144
---

diff --git a/source3/lib/gencache.c b/source3/lib/gencache.c
index 528414bd66e..6f7734c2004 100644
--- a/source3/lib/gencache.c
+++ b/source3/lib/gencache.c
@@ -301,9 +301,6 @@ bool gencache_set_data_blob(const char *keystr, DATA_BLOB blob,
 	if (hdr_len == -1) {
 		return false;
 	}
-	if ((blob.length + (size_t)hdr_len) < blob.length) {
-		return false;
-	}
 
 	dbufs[0] = (TDB_DATA) { .dptr = (uint8_t *)hdr, .dsize = hdr_len };
 	dbufs[1] = (TDB_DATA) { .dptr = blob.data, .dsize = blob.length };