From: Evan You <yyx990803@gmail.com>
Date: Wed, 24 Apr 2024 09:27:51 +0000 (+0800)
Subject: refactor: should throw errors in computed getters
X-Git-Tag: v3.5.0-alpha.1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=85f3592725e18316762abb86dd521ebf10ad22e3;p=thirdparty%2Fvuejs%2Fcore.git

refactor: should throw errors in computed getters
---

diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
index 90db99cf77..e361e85404 100644
--- a/packages/reactivity/src/effect.ts
+++ b/packages/reactivity/src/effect.ts
@@ -375,12 +375,13 @@ export function refreshComputed(computed: ComputedRefImpl) {
     }
   } catch (err) {
     dep.version++
+    throw err
+  } finally {
+    activeSub = prevSub
+    shouldTrack = prevShouldTrack
+    cleanupDeps(computed)
+    computed.flags &= ~EffectFlags.RUNNING
   }
-
-  activeSub = prevSub
-  shouldTrack = prevShouldTrack
-  cleanupDeps(computed)
-  computed.flags &= ~EffectFlags.RUNNING
 }
 
 function removeSub(link: Link) {