From: Kuan-Wei Chiu Date: Sun, 11 Jan 2026 18:49:15 +0000 (+0000) Subject: hw/misc/virt_ctrl: Fix incorrect trace event in read operation X-Git-Tag: v11.0.0-rc0~56^2~20 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=8608ed356ef90815cc5bcf04fcdbde987fd24bca;p=thirdparty%2Fqemu.git hw/misc/virt_ctrl: Fix incorrect trace event in read operation The virt_ctrl_read() function currently invokes trace_virt_ctrl_write() instead of trace_virt_ctrl_read(). This results in read operations appearing as write operations in the trace output, which is misleading during debugging and analysis. Replace the incorrect trace call with the proper read-specific trace event to accurately reflect the hardware behavior. Fixes: 0791bc02b8fb ("m68k: add a system controller") Signed-off-by: Kuan-Wei Chiu Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20260111184915.1363318-1-visitorckw@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- diff --git a/hw/misc/virt_ctrl.c b/hw/misc/virt_ctrl.c index 40747925a29..9b82e97ffde 100644 --- a/hw/misc/virt_ctrl.c +++ b/hw/misc/virt_ctrl.c @@ -43,7 +43,7 @@ static uint64_t virt_ctrl_read(void *opaque, hwaddr addr, unsigned size) break; } - trace_virt_ctrl_write(s, addr, size, value); + trace_virt_ctrl_read(s, addr, size, value); return value; }