From: Ján Tomko <jtomko@redhat.com>
Date: Fri, 10 Aug 2012 13:20:43 +0000 (+0200)
Subject: virsh: say save-image-edit failed only when it does
X-Git-Tag: v0.10.0-rc1~158
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=863399f06b8dad8d7fc2e4b962d3cc566b69ed4c;p=thirdparty%2Flibvirt.git

virsh: say save-image-edit failed only when it does

The common code for editing files in virsh-edit.c expects EDIT_DEFINE to
return 0 on failure. virDomainSaveImageDefineXML returns 0 on success.
---

diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 33b1727f94..69e0133450 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -2973,7 +2973,7 @@ cmdSaveImageEdit(vshControl *ctl, const vshCmd *cmd)
                     "not changed.\n"), file);           \
     ret = true; goto edit_cleanup;
 #define EDIT_DEFINE \
-    virDomainSaveImageDefineXML(ctl->conn, file, doc_edited, define_flags)
+    (virDomainSaveImageDefineXML(ctl->conn, file, doc_edited, define_flags) == 0)
 #define EDIT_FREE /* */
 #include "virsh-edit.c"