From: Jouni Malinen <j@w1.fi>
Date: Sat, 7 Jun 2014 14:39:51 +0000 (+0300)
Subject: WPS: Check for theoretical gmtime() failure
X-Git-Tag: hostap_2_3~346
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=86388afa56ff9a627caefd7c55f2873bb1688776;p=thirdparty%2Fhostap.git

WPS: Check for theoretical gmtime() failure

In theory, gmtime() could return NULL if the year value would not fit
into an integer. However, that cannot really happen with the current
time() value in practice. Anyway, clean up static analyzer reports by
checking for this corner case.

Signed-off-by: Jouni Malinen <j@w1.fi>
---

diff --git a/src/wps/wps_upnp.c b/src/wps/wps_upnp.c
index 6fb3d4c55..f62b49e60 100644
--- a/src/wps/wps_upnp.c
+++ b/src/wps/wps_upnp.c
@@ -227,6 +227,8 @@ void format_date(struct wpabuf *buf)
 
 	t = time(NULL);
 	date = gmtime(&t);
+	if (date == NULL)
+		return;
 	wpabuf_printf(buf, "%s, %02d %s %d %02d:%02d:%02d GMT",
 		      &weekday_str[date->tm_wday * 4], date->tm_mday,
 		      &month_str[date->tm_mon * 4], date->tm_year + 1900,